From 92995e0d38dc00e930c562cf936220f83c09d082 Mon Sep 17 00:00:00 2001
From: Paulo Andrade <pandrade@redhat.com>
Date: Tue, 23 Jul 2024 12:03:30 -0400
Subject: [PATCH] rpc-gssd.service has status failed (due to rpc.gssd segfault)
 
Ensure strings are not NULL before doing a strdup() in error path.
 
Fixes: https://issues.redhat.com/browse/RHEL-43286
Signed-off-by: Steve Dickson <steved@redhat.com>
 
Reference:https://git.linux-nfs.org/?p=steved/nfs-utils.git;a=commit;h=92995e0d38dc00e930c562cf936220f83c09d082
Conflict:no
---
 utils/gssd/gssd.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
 
diff --git a/utils/gssd/gssd.c b/utils/gssd/gssd.c
index d7a2822..01ce7d1 100644
--- a/utils/gssd/gssd.c
+++ b/utils/gssd/gssd.c
@@ -365,12 +365,12 @@ gssd_read_service_info(int dirfd, struct clnt_info *clp)
 
 fail:
 	printerr(0, "ERROR: failed to parse %s/info\n", clp->relpath);
-	clp->upcall_address = strdup(address);
-	clp->upcall_port = strdup(port);
+	clp->upcall_address = address ? strdup(address) : NULL;
+	clp->upcall_port = port ? strdup(port) : NULL;
 	clp->upcall_program = program;
 	clp->upcall_vers = version;
-	clp->upcall_protoname = strdup(protoname);
-	clp->upcall_service = strdup(service);
+	clp->upcall_protoname = protoname ? strdup(protoname) : NULL;
+	clp->upcall_service = service ? strdup(service) : NULL;
 	free(servername);
 	free(protoname);
 	clp->servicename = NULL;
-- 
1.8.3.1