CONTRIBUTING_EN.md · 叶成美/samples_hi3796

English|[中文](README_CN.md)

**Introduction**

Welcome to use Ascend Samples!

**Contribution Requirements**

The submitted project files shall contain at least the source code, readme file, and build and run scripts.

Sign the contribution license agreement (CLA) before your submission. [Link](https://clasign.osinfra.cn/sign/Z2l0ZWUlMkZhc2NlbmQ=)

**I. Source Code**

1. For online build and run, please use C++ or Python and comply with part 4 of programming specifications. (Currently, only C++ samples are available.)

2. For C++ PR sample specifications, see [sample](./cplusplus/level2_simple_inference/1_classification/googlenet_imagenet_picture).

3. Organization of the project directory:   
    
    - The project directory has a **src** folder for storing the source code.   
    - The project directory has a readme file (in .md format).   
    - Place the user testcase test script in the st folder under the samples directory, place the test script of the C++ project under cplusplus, and place the test script of the python project under the python folder. The naming rule is required to be testcase_ + "project name" + .sh, where the project name is the upper-level directory name of the src folder of the corresponding project.     
      **Take the C++ YOLOV3_coco_detection_picture example as an example:**    
      **The sample src directory is:** samples/cplusplus/level2_simple_inference/2_object_detection/YOLOV3_coco_detection_picture/src    
      **So the script of the sample testcase is:** st/cplusplus/testcase_YOLOV3_coco_detection_picture.sh
    
    > **Description:**
    >- Each entry script corresponds to two device forms, and the current project is required to adapt to these two device forms: Atlas200dk, A300-3010.
    >- Each device form corresponds to one or more versions, and the current project is required to adapt to at least one version. 
    >- The current test environment: 1. Atlas200dk and A300-3010 of CANN 5.0.3.alpha005. 2. Atlas200dk and A300-3010 of CANN 5.0.4.alpha002.
    >- Note: The content in blacklist_version.conf is the blacklist version, that is, the testcase will not be run on this version. Such as testcase_YOLOV3_coco_detection_picture: 5.0.3.alpha005

4. For code migrated from other open-source software, add the license declaration.

**II. License Rules**

**You need to declare according to the type of CLA you have signed:**    
**CLA signing website: https://clasign.osinfra.cn/sign/Z2l0ZWUlMkZhc2NlbmQ=**    
**CLA includes three types: enterprise signature, employee signature, and individual signature. Non-Huawei employees sign the individual and declare the corresponding copyright according to the type signed by themselves.**    
**All newly created source files (cpp, py, h, etc.) need to support the Apache 2.0 License, and add the following statement to the head of the source file, replace [yyyy] with the 4-digit year of the code creation, and replace [ name of the copyright owner] is replaced with the name of the organization (all individuals signing the CLA shall declare Huawei Technologies Co., Ltd), please remove the square brackets:**   
```
# Copyright [yyyy] [name of copyright owner]
#
# Licensed under the Apache License, Version 2.0 (the "License");
# You may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
```
**All the code modified from other source code, do not change the LICENSE type in the source code. If the source code has the copyright of other company, the original copyright statement remains unchanged, add a line of Copyright above, and change [yyyy] Replace with the 4-digit year of the modified code, replace [name of the copyright owner] with the name of your organization (all individuals signing the CLA shall declare Huawei Technologies Co., Ltd), and remove the square brackets.**   
E.g:
```
# Copyright [yyyy] [name of copyright owner]
# Copyright 2018 HiSillion Technologies Co., Ltd.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# You may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
```

**III. Readme**

The readme file provides guidance for you to understand and deploy your sample. It must contain the following content:

1. Overview

Describes the function, operation methods, and model source of the project.

2. Key requirements:

(1) Project function, including the input and output of the sample.   
    (2) Environment variables, third-party software dependencies, and libraries, and installation methods.   
    (3) Project file download methods, by using a compressed package or the **git clone** command.   
    (4) Model download method from [ModelZoo](https://gitee.com/ascend/modelzoo).  
    (5) Input requirements for offline model conversion.   
    (6) Test data (bin files, images, and videos) download method (OBS or web disk links).   
    (7) Command for converting an original model to a Da Vinci model.   
    (8) Project build and run procedure.  
    (9) Post-inference validation method (by using a shell script or Python script).

**IV. Regulations on PR Submission**

For details about how to submit a PR, see [How Do I Fork a Repository and Submit a PR?](https://gitee.com/ascend/samples/wikis/%E5%A6%82%E4%BD%95fork%E4%BB%93%E5%BA%93%E5%B9%B6%E6%8F%90%E4%BA%A4PR?sort_id=3271318).

A submitted PR sample must contain the required items, project test cases, and a readme file.

1. Overview

- Required items:

1. The project directory has a **src** folder for storing the source code.   
        2. The project directory has a readme file (in .md format).   
        3. There is testcase*.sh in the st directory (sample function test script).

- After the PR is submitted, the access control pipeline will be automatically triggered, and the background will be compiled according to the use case entry shell (the testcase*.sh in the programming language folder under the st directory). Note the following points:

1. The PR shall not contain the **rm** command.   
        2. The PR shall not upload the original model and converted Da Vinci model.   
        3. The PR shall not upload the test dataset and validation dataset.

2. The testcase*.sh in the corresponding programming language folder under the st directory should contain the function of reasoning and verifying the result of the reasoning. The specific definition is as follows:
  
    The inference phase shall include the following actions:   
    - Download the test dataset and validation dataset.    
    - Download the original model.   
    - Set the environment variables required for model conversion.   
    - Run the **atc** command to convert the model.   
    - Set the environment variables required for building the project.   
    - Set the environment variables required for running the application.  
    - Run the application.

Verify the result of the inference (provide different methods of verifying the inference result according to different projects, the verification method can be written in the script):  
    - If an error occurs in the inference phase, **inferenceError** is returned.     
    - If an error occurs in the validation phase, **verifyResError** is returned.    
    - If both phases are successful, a success message is returned.

3. The necessary components and Python 3.6.9 environment have been pre-installed in the operating environment. Python 3.6.9 can be installed using the **python3.6** command. The third-party library dependencies can be installed using either **pip3 install package --user** or **python3.6 -m pip install package --user**.

4. The model has been uploaded to the ModelZoo according to the [Contribution guide](https://gitee.com/ascend/modelzoo) repository. Provide OBS or web disk links for downloading the validation files (binaries, images, and videos). Alternatively, contact the administrator to store the files to a fixed OBS address. Do not store the files in the samples repository.

5. For environment and other problems, please submit an issue.

6. For details about how to submit test cases, see the [PR Submission Sample](./cplusplus/level2_simple_inference/1_classification/googlenet_imagenet_picture).

**V. Programming Specifications**

- Specifications and Standards

1. C++ programming complies with the [Google C++ Coding Guidelines](http://google.github.io/styleguide/cppguide.html). Unit testing (UT) complies with the [Googletest Primer](https://github.com/google/googletest/blob/master/googletest/docs/primer.md).

2. Python programming complies with the [Python PEP 8 Coding Style](https://pep8.org/). Unit testing (UT) complies with the [pytest framework](http://www.pytest.org/en/latest/).

- Remarks

1. Use the string data type preferentially. Avoid the use of the char* data type.   
    2. Do not use **printf**. Instead, use **cout**.   
    3. Use smart pointers for memory management.   
    4. Do not call **exit** in functions.   
    5. Do not use tools such as an IDE to automatically generate code.   
    6. Minimize third-party library dependencies. If a third-party dependency is imported, the installation and usage description must be provided.   
    7. Use English comments with a comment rate within 30%–40%. Self-commenting is encouraged.   
    8. Provide comments in the function header to describe the function purpose, input parameters, and output parameters.   
    9. Provide unified error codes to facilitate error locating.   
    10. Avoid printing error-level logs that have no impact on the system.   
    11. Remove commented useless code lines. The purpose of comments shall not be removing useless code lines.

叶成美/samples_hi3796

简介

发行版

贡献者

近期动态

叶成美/samples_hi3796 .gitee-modal { width: 500px !important; }

简介

发行版

贡献者

近期动态

搜索帮助

叶成美/samples_hi3796