checklist.md · duoluodexiaokeke/tidb

forked from 平凯星辰（北京）科技有限公司/tidb

加入 Gitee

与超过 1200万开发者一起发现、参与优秀开源项目，私有仓库也完全免费：）

免费加入

文件

克隆/下载

checklist.md 975 Bytes

一键复制编辑原始数据按行查看历史

提交于 2017-06-05 10:58 . Format checklist.md (#3382)

# Following the checklist saves the reviewers' time and gets your PR reviewed faster.

# Self Review
Have you reviewed every line of your changes by yourself?

# Test
Have you added enough test cases to cover the new feature or bug fix?
Also, add comments to describe your test cases.

# Naming
Do function names keep consistent with its behavior?
Is it easy to infer the function's behavior by its name?

# Comment
Is there any code that confuses the reviewer?
Add comments on them! You'll be asked to do so anyway.
Make sure there is no syntax or spelling error in your comments.
Some online syntax checking tools like Grammarly may be helpful.

# Refactor
Is there any way to refactor the code to make it more readable?
If the refactoring touches a lot of existing code, send another PR to do it.

# Single Purpose
Make sure the PR does only one thing and nothing else.

# Diff Size
Make sure the diff size is no more than 500, split it into small PRs if it is too large.

马建仓 AI 助手

尝试更多

代码解读

代码找茬

代码优化

https://gitee.com/duoluodexiaokeke/tidb.git

git@gitee.com:duoluodexiaokeke/tidb.git

duoluodexiaokeke

tidb

master

duoluodexiaokeke/tidb

简介

发行版

贡献者

近期动态

duoluodexiaokeke/tidb .gitee-modal { width: 500px !important; }

简介

发行版

贡献者

近期动态

搜索帮助

duoluodexiaokeke/tidb